Hive Gateway v2 #956

EmrysMyrddin · 2025-03-27T13:24:40Z

No description provided.

Copilot

Pull Request Overview

This PR introduces the v2.0.0 release of the @graphql-hive/gateway package with significant improvements to OpenTelemetry instrumentation and upstream retry functionality. Key changes include a rework of upstream retry handling with new types and symbols, enhancements to tracing spans with updated context propagation and attributes, and updates to e2e tests to reflect new span expectations.

Reviewed Changes

Copilot reviewed 20 out of 22 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
packages/runtime/src/plugins/useUpstreamTimeout.ts	Simplified upstream timeout handling by removing the combined signal.
packages/runtime/src/plugins/useUpstreamRetry.ts	Introduced RETRY_SYMBOL and helper functions for upstream retry with improved type definitions and executor adjustments.
packages/runtime/src/index.ts	Updated exports to include new retry-related functions.
packages/plugins/opentelemetry/**	Overhauled several utilities and span creation functions to improve OpenTelemetry trace context propagation and attribute setting.
packages/plugins/hmac-upstream-signature/src/index.ts	Simplified updating of executionRequest.extensions by removing the setExecutionRequest helper.
packages/fusion-runtime/**	Updated executor wrapping to integrate new instrumentation handling and unified graph manager changes.
e2e/opentelemetry/ & e2e/cloudflare-workers/	Adjusted test expectations and minor numeric literal formatting improvements.
.changeset/pink-sloths-mate.md	Documented breaking changes and improvements for the OpenTelemetry integration.

Files not reviewed (2)

package.json: Language not supported
packages/plugins/opentelemetry/package.json: Language not supported

Comments suppressed due to low confidence (1)

packages/plugins/opentelemetry/src/spans.ts:280

The conditional check does not currently handle cases where the execution result is an async iterable. Consider extending the logic to properly handle async iterable results or update the comment if this behavior is intentional.

if (!isAsyncIterable(result) && result.errors && result.errors.length > 0) {

e2e/opentelemetry/opentelemetry.e2e.ts

theguild-bot · 2025-03-27T13:27:52Z

🚀 Snapshot Release (`alpha`)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package	Version	Info
`@graphql-tools/batch-delegate`	`9.0.37-alpha-cf354599f0bca73b6f8b010a6747e42a17ef20d7`	npm ↗︎ unpkg ↗︎
`@graphql-tools/batch-execute`	`9.0.17-alpha-cf354599f0bca73b6f8b010a6747e42a17ef20d7`	npm ↗︎ unpkg ↗︎
`@graphql-tools/delegate`	`10.2.19-alpha-cf354599f0bca73b6f8b010a6747e42a17ef20d7`	npm ↗︎ unpkg ↗︎
`@graphql-tools/executor-http`	`2.0.2-alpha-cf354599f0bca73b6f8b010a6747e42a17ef20d7`	npm ↗︎ unpkg ↗︎
`@graphql-tools/federation`	`3.2.3-alpha-cf354599f0bca73b6f8b010a6747e42a17ef20d7`	npm ↗︎ unpkg ↗︎
`@graphql-mesh/fusion-runtime`	`0.11.14-alpha-cf354599f0bca73b6f8b010a6747e42a17ef20d7`	npm ↗︎ unpkg ↗︎
`@graphql-hive/gateway`	`1.14.3-alpha-cf354599f0bca73b6f8b010a6747e42a17ef20d7`	npm ↗︎ unpkg ↗︎
`@graphql-hive/nestjs`	`1.0.14-alpha-cf354599f0bca73b6f8b010a6747e42a17ef20d7`	npm ↗︎ unpkg ↗︎
`@graphql-hive/plugin-aws-sigv4`	`1.0.11-alpha-cf354599f0bca73b6f8b010a6747e42a17ef20d7`	npm ↗︎ unpkg ↗︎
`@graphql-mesh/plugin-opentelemetry`	`2.0.0-alpha-cf354599f0bca73b6f8b010a6747e42a17ef20d7`	npm ↗︎ unpkg ↗︎
`@graphql-mesh/plugin-prometheus`	`1.3.46-alpha-cf354599f0bca73b6f8b010a6747e42a17ef20d7`	npm ↗︎ unpkg ↗︎
`@graphql-hive/gateway-runtime`	`1.9.0-alpha-cf354599f0bca73b6f8b010a6747e42a17ef20d7`	npm ↗︎ unpkg ↗︎
`@graphql-tools/stitch`	`9.4.24-alpha-cf354599f0bca73b6f8b010a6747e42a17ef20d7`	npm ↗︎ unpkg ↗︎
`@graphql-tools/stitching-directives`	`3.1.34-alpha-cf354599f0bca73b6f8b010a6747e42a17ef20d7`	npm ↗︎ unpkg ↗︎
`@graphql-mesh/transport-http`	`0.6.42-alpha-cf354599f0bca73b6f8b010a6747e42a17ef20d7`	npm ↗︎ unpkg ↗︎
`@graphql-mesh/transport-http-callback`	`0.6.1-alpha-cf354599f0bca73b6f8b010a6747e42a17ef20d7`	npm ↗︎ unpkg ↗︎
`@graphql-tools/wrap`	`10.0.37-alpha-cf354599f0bca73b6f8b010a6747e42a17ef20d7`	npm ↗︎ unpkg ↗︎

theguild-bot · 2025-03-27T13:30:40Z

🚀 Snapshot Release (Binary for `Linux-ARM64`)

The latest changes of this PR are available for download (based on the declared changesets).

theguild-bot · 2025-03-27T13:30:50Z

🚀 Snapshot Release (Binary for `Linux-X64`)

The latest changes of this PR are available for download (based on the declared changesets).

theguild-bot · 2025-03-27T13:31:01Z

🚀 Snapshot Release (Binary for `macOS-ARM64`)

The latest changes of this PR are available for download (based on the declared changesets).

theguild-bot · 2025-03-27T13:32:28Z

🚀 Snapshot Release (Node Docker Image)

The latest changes of this PR are available as image on GitHub Container Registry (based on the declared changesets):

ghcr.io/graphql-hive/gateway:1.14.3-alpha-cf354599f0bca73b6f8b010a6747e42a17ef20d7

theguild-bot · 2025-03-27T13:34:03Z

🚀 Snapshot Release (Bun Docker Image)

The latest changes of this PR are available as image on GitHub Container Registry (based on the declared changesets):

ghcr.io/graphql-hive/gateway:1.14.3-alpha-cf354599f0bca73b6f8b010a6747e42a17ef20d7-bun

theguild-bot · 2025-03-27T13:34:32Z

🚀 Snapshot Release (Binary for `macOS-X64`)

The latest changes of this PR are available for download (based on the declared changesets).

theguild-bot · 2025-03-27T13:37:52Z

🚀 Snapshot Release (Binary for `Windows-X64`)

The latest changes of this PR are available for download (based on the declared changesets).

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Valentin Cocaud <[email protected]>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…#967)

Copilot AI review requested due to automatic review settings March 27, 2025 13:24

Copilot AI reviewed Mar 27, 2025

View reviewed changes

e2e/opentelemetry/opentelemetry.e2e.ts Outdated Show resolved Hide resolved

EmrysMyrddin marked this pull request as draft March 27, 2025 13:25

EmrysMyrddin force-pushed the v2 branch 3 times, most recently from b726aed to 376b8e3 Compare March 27, 2025 22:55

enisdenjo force-pushed the v2 branch from 376b8e3 to e101965 Compare April 8, 2025 19:10

enisdenjo changed the title ~~🚧 @graphql-hive/gateway v2.0.0 🚧~~ Hive Gateway v2 Apr 8, 2025

enisdenjo force-pushed the v2 branch 2 times, most recently from 7ac617e to 3563e2b Compare April 11, 2025 17:50

EmrysMyrddin force-pushed the v2 branch from 3563e2b to 2881d4f Compare April 12, 2025 11:11

enisdenjo force-pushed the v2 branch 4 times, most recently from b561837 to 2db2c99 Compare April 21, 2025 12:30

enisdenjo force-pushed the v2 branch from 2db2c99 to 705d9cc Compare May 12, 2025 12:07

enisdenjo force-pushed the v2 branch from db98fd5 to 9a787b9 Compare May 20, 2025 16:47

EmrysMyrddin and others added 5 commits May 22, 2025 17:31

feat(opentelemetry): correct span parenting + fix batching support

3a4f65c

chore(dependencies): updated changesets for modified dependencies

2adc7f1

feat(opentelemetry): remove Azure exporter (#957)

c84b528

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

chore(dependencies): updated changesets for modified dependencies

74a26bd

Update OpenTelemetry to v2 (#875)

2640dbf

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Valentin Cocaud <[email protected]>

github-actions bot and others added 12 commits May 22, 2025 17:31

chore(dependencies): updated changesets for modified dependencies

54ef864

chore(dependencies): updated changesets for modified dependencies

0399156

feat(opentelemetry): Allow to use the plugin in Yoga (#965)

ab6c98a

feat(opentelemetry): add cache events and attributes (#993)

35b4c59

feat(opentelemetry): Use env variables for resource attributes (#1036)

87ee10e

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

feat(opentelemetry): Exporters config is optional (#966)

f4a5e1c

feat(opentelemetry): add sampling rate (#968)

14b38b2

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

feat(opentelemetry): add support for b3 + jaeger + custom propagators (…

1e63bc9

…#967)

mutate execution request because we strict compare

7e74cd7

upstreamtimeout needs to change executionrequest instance

8c790a3

use timeout deferred making sure promise is not hanging

f5229c5

feat(opentelemetry): add background spans (schema + init) (#1071)

cf35459

enisdenjo force-pushed the v2 branch from 1d0e4b4 to cf35459 Compare May 22, 2025 15:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Hive Gateway v2 #956

Hive Gateway v2 #956

Uh oh!

EmrysMyrddin commented Mar 27, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

theguild-bot commented Mar 27, 2025 •

edited

Loading

Uh oh!

theguild-bot commented Mar 27, 2025 •

edited

Loading

Uh oh!

theguild-bot commented Mar 27, 2025 •

edited

Loading

Uh oh!

theguild-bot commented Mar 27, 2025 •

edited

Loading

Uh oh!

theguild-bot commented Mar 27, 2025 •

edited

Loading

Uh oh!

theguild-bot commented Mar 27, 2025 •

edited

Loading

Uh oh!

theguild-bot commented Mar 27, 2025 •

edited

Loading

Uh oh!

theguild-bot commented Mar 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

Hive Gateway v2 #956

Are you sure you want to change the base?

Hive Gateway v2 #956

Uh oh!

Conversation

EmrysMyrddin commented Mar 27, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

theguild-bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Snapshot Release (alpha)

Uh oh!

theguild-bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Snapshot Release (Binary for Linux-ARM64)

Uh oh!

theguild-bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Snapshot Release (Binary for Linux-X64)

Uh oh!

theguild-bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Snapshot Release (Binary for macOS-ARM64)

Uh oh!

theguild-bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Snapshot Release (Node Docker Image)

Uh oh!

theguild-bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Snapshot Release (Bun Docker Image)

Uh oh!

theguild-bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Snapshot Release (Binary for macOS-X64)

Uh oh!

theguild-bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Snapshot Release (Binary for Windows-X64)

Uh oh!

Uh oh!

theguild-bot commented Mar 27, 2025 •

edited

Loading

🚀 Snapshot Release (`alpha`)

theguild-bot commented Mar 27, 2025 •

edited

Loading

🚀 Snapshot Release (Binary for `Linux-ARM64`)

theguild-bot commented Mar 27, 2025 •

edited

Loading

🚀 Snapshot Release (Binary for `Linux-X64`)

theguild-bot commented Mar 27, 2025 •

edited

Loading

🚀 Snapshot Release (Binary for `macOS-ARM64`)

theguild-bot commented Mar 27, 2025 •

edited

Loading

theguild-bot commented Mar 27, 2025 •

edited

Loading

theguild-bot commented Mar 27, 2025 •

edited

Loading

🚀 Snapshot Release (Binary for `macOS-X64`)

theguild-bot commented Mar 27, 2025 •

edited

Loading

🚀 Snapshot Release (Binary for `Windows-X64`)