feat(wrap): allow making the new field type Nullable #1150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MkMan
force-pushed
the
allow-specifying-field-nullability-when-wrapping
branch
3 times, most recently
from
802e2da to
aeb54c3
Compare
enisdenjo
requested changes
May 26, 2025
MkMan
force-pushed
the
allow-specifying-field-nullability-when-wrapping
branch
from
aeb54c3 to
8b993f1
Compare
Done, thanks for reviewing it @enisdenjo 🙂 |
enisdenjo
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow providing an optional configuration object to control the nullability of the new Wrapper field.
Why
While recently investigating an incident we suffered I discovered that fields Wrapped under a new field are automatically marked as required (NonNull).
In our case this caused a problem because the fields were from an external stitched schema and when the API returned
nullour service crashed as it expected something back.Comments
I couldn't find contributing guidelines so please provide me any feedback needed to make this change in a way that aligns with the repo's standards and direction.
Many thanks 😃