New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dynamic exchange additions - remove hardcoded list #23

Merged

davekaj merged 2 commits into graphprotocol:master from ianlapham:dynamic-sources

Dec 18, 2019

Contributor

ianlapham commented Dec 17, 2019 •

edited

Loading

Fix for #15

Currenlty we rely on a hardcoded list of exchanges to populate token specific fields like symbol, name and decimals
Use new graph features to "try/catch" with various ERC20 abis
General strategy is to try with standard ERC20 abi, if call is reverted try with variation that uses bytes

ianlapham added 2 commits

December 17, 2019 10:58


          initial setup

87102d2


          add dynamic contract checks and additional abis

6ced798

Contributor

davekaj commented Dec 18, 2019

Looks great!

davekaj merged commit 7c1ea71 into graphprotocol:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet