Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hardcoded exchanges to be dynamically added #15

Open
davekaj opened this issue Sep 5, 2019 · 1 comment
Open

Change hardcoded exchanges to be dynamically added #15

davekaj opened this issue Sep 5, 2019 · 1 comment

Comments

@davekaj
Copy link
Contributor

davekaj commented Sep 5, 2019

Good timing, apparently the issue that was blocking us from doing dynamic data sources is fixed graphprotocol/graph-node#892 .

I haven't looked into it deeply, but from what I interpret, we can now get null returned instead of the graph node crashing. This should allow us to handle all contracts dynamically. This will also allow us to make token, decimals, and name all required in schema.graphql (Noah did this in his PR but I just noticed we didn't add it in Ians PR)

@ianlapham take a look at this, let me know if you have any questions. If you can implement it that would be amazing! This week I am busy but I can get to it next week. If you need help reach out on discord.

@ianlapham
Copy link
Contributor

This is perfect - I'm going to make another PR that has these changes. Thanks for the help digging into all of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants