fix(gnd): surface anyhow error chains in error output#6622
Open
mvanhorn wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gnderror output now surfaces the full anyhow error chain instead of only the top-level message. The bare{}Display formattings inmain.rsandwatch.rsprinted just the outermost context (for examplefailed to load manifest), hiding the underlying cause a developer needs to act on; they now use the alternate{:#}chain rendering. The two bareserde_yaml::from_str()?sites incommands/build.rsandmanifest.rsgain context so YAML parse failures name the file being parsed.Why this matters
Issue #6360 reports that gnd swallows error causes, leaving developers with messages like
Error: failed to start watch modeand no underlying reason. The silenced chains were verified atmain.rs:266andwatch.rs:49/104before the change. This covers the error-display half of the issue; the issue also discusses restructuring some error sites to attach more context at creation time, which is a larger refactor left for a follow-up.Testing
A new unit test asserts a manifest parse failure renders with its cause chain (file name + YAML error) rather than the bare context string.
cargo fmt --checkandcargo check -p gndpass; the new manifest error-chain test passes.Refs #6360