feat: remove asset holder allowlist, with additional fixes #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Staking.setAssetHolder is removed and the assetHolders mapping is deprecated.
Signed-off-by: Tomás Migone <[email protected]>
- Add a comment about the risk of tx being confirmed late causing tokens to be burnt (TRST-L-1) - Return early to avoid emitting an event if query fees are zero - Remove comment about only valid senders being able to call collect(). BREAKING CHANGE: collect() does not emit AllocationCollected if query fees are zero
fix: improvements from Trust audit (TRST-L-1 and recommendations)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #864 +/- ##
==========================================
+ Coverage 92.60% 92.69% +0.08%
==========================================
Files 47 47
Lines 2368 2394 +26
Branches 432 435 +3
==========================================
+ Hits 2193 2219 +26
Misses 175 175
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pcarranzav
force-pushed
the
pcv/require-epoch-for-collect
branch
from
3fe1edb to
3882b35
Compare
This was referenced Nov 24, 2023
feat: remove asset holder allowlist, with additional fixes
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
tmigone
reviewed
Dec 7, 2023
| * @param _tokensIn Amount of tokens used to mint signal | ||
| * @return Amount of tokens that would be recovered after minting and burning signal | ||
| */ | ||
| function tokensToSignalToTokensNoTax(bytes32 _subgraphDeploymentID, uint256 _tokensIn) |
There was a problem hiding this comment.
tokensToSignalToTokensNoTaxFinalFinalVersion4.docx
tmigone
requested changes
Dec 7, 2023
Maikol
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.