Add multicall to staking contract + keep legacy bulk calls #550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This implementation adds Multicall to the Staking contract but keeps the current bulk function calls:
closeAllocationMany() closeAndAllocate() claimMany()to make the upgrade process easier for the indexer-agent. Once indexers are using the new version, those functions should be removed on any next upgrade.Audit
The originally audited code is on PR #475 and this PR just restore the removed function calls on the last commit 8229e8b.
Second Phase
Any second upgrade should be based on PR #475 that removes the legacy bulk calls.