That wasn't user-supplied options

benjie · benjie · commit 56861ae4cfd9 · 2024-11-22T15:12:51.000Z
diff --git a/src/interfaces.ts b/src/interfaces.ts
@@ -739,7 +739,7 @@ export interface WorkerOptions extends WorkerSharedOptions {
    */
   workerId?: string;
 
-  abortSignal?: AbortSignal;
+  abortSignal: AbortSignal;
 
   workerPool: WorkerPool;
 
diff --git a/src/main.ts b/src/main.ts
@@ -584,8 +584,6 @@ export function _runTaskList(
   }
 
   const abortController = new AbortController();
-  // TODO: user-passed abortSignal should trigger our controller to abort
-
   const abortSignal = abortController.signal;
   const abortPromise = new Promise<void>((_resolve, reject) => {
     abortSignal.addEventListener("abort", () => {

Original file line number	Diff line number	Diff line change
`@@ -584,8 +584,6 @@ export function _runTaskList(`
`584`	`584`	`}`
`585`	`585`
`586`	`586`	`const abortController = new AbortController();`
`587`		`- // TODO: user-passed abortSignal should trigger our controller to abort`
`588`		`-`
`589`	`587`	`const abortSignal = abortController.signal;`
`590`	`588`	`const abortPromise = new Promise<void>((_resolve, reject) => {`
`591`	`589`	`abortSignal.addEventListener("abort", () => {`