Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates readme to point to latest @apollo client npm package #9

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dangerdespain
Copy link

Description

Readme update to point toward the latest @apollo client package

Performance impact

None

Security impact

Unknown

Updates readme to point to the latest @apollo package path
@dangerdespain dangerdespain changed the title Dangerdespain readme patch Updates readme to point to latest @apollo client npm package Nov 23, 2021
@benjie
Copy link
Member

benjie commented Nov 24, 2021

Does this work with that version?

@dangerdespain
Copy link
Author

So far so good on my end! FWIW, I was unable to get persisted operations working w/ apollo-link-persisted-queries and Apollo client v3.4.x, which led me to this change.

@dangerdespain
Copy link
Author

dangerdespain commented Nov 24, 2021

I'm glad you asked though! I was checking things out and realized that I had found a working package, but apparently not the correct package.

https://github.com/apollographql/apollo-link-persisted-queries has a deprecation notice at the top of the readme pointing to these updated docs. The correct import now appears to be import { createPersistedQueryLink } from "@apollo/client/link/persisted-queries"; - I'll update the MR!

Updates persisted queries import to correct @apollo/client package
@@ -217,10 +217,10 @@ postgraphile \
#### Apollo Client

You can configure Apollo Client to send the persisted operations generated by
`graphql-codegen` with `apollo-link-persisted-queries`:
`graphql-codegen` with `@apollo/link-persisted-queries`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be @apollo/client?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants