Skip to content

Fix C# 14 breaking change: Replace params ReadOnlySpan with params arrays #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Fix C# 14 breaking change: Replace params ReadOnlySpan with params arrays #627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ac1f34
Initial plan
Copilot Oct 12, 2025
94d90f4
Fix C# 14 breaking change by replacing params ReadOnlySpan with param…
Copilot Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Business/Grand.Business.Core/Interfaces/Storage/IFileStore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ public static class IFileStoreExtensions
/// <param name="fileStore">The <see cref="IFileStore" />.</param>
/// <param name="paths">The path parts to combine.</param>
/// <returns>The full combined path.</returns>
public static string Combine(this IFileStore fileStore, params ReadOnlySpan<string> paths)
public static string Combine(this IFileStore fileStore, params string[] paths)
{
if (paths.Length == 0)
return null;
Expand Down
2 changes: 1 addition & 1 deletion src/Business/Grand.Business.Core/Utilities/Messages/DotLiquidDrops/LiquidExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ namespace Grand.Business.Core.Utilities.Messages.DotLiquidDrops;

public static class LiquidExtensions
{
public static List<string> GetTokens(params ReadOnlySpan<Type> drops)
public static List<string> GetTokens(params Type[] drops)
{
List<string> tokens = [];
foreach (var drop in drops)
Expand Down