-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump C_KZG_4844_GIT_HASH #257
Bump C_KZG_4844_GIT_HASH #257
Conversation
Ok, so this is a funny - there is some issue when |
It's multiple definitions of some Nim primitives. ![Screenshot_20240126-093536743.png](https://github.![Screenshot_20240126-093608207.png](https://github.com/sifraitech/rust-kzg/assets/22738317/659000b5-72c1-4d4a-a101-4005ae6a5357) b-4c3e-bc22-c691f8a29fed) There is a workaround iirc but have to check and try myself (on mobile) |
To ensure there is no naming conflict, Nim core functions can be exported to a RTL (Runtime Library) file: https://nim-lang.org/nimc.html#dll-generation I think Constantine itself might be RTL-free as I purposely avoided all dependencies on Nim stdlib but I might have missed something or use convenient types like In the meantime I think it's reasonable to point to Constantine directly. |
Thanks for information @mratsim . Let's close it for now and reopen of this if this rare use-case will be hit. |
In this PR:
C_KZG_4844_GIT_HASH
to latest c-kzg-4844 commit (5115420
)