Skip to content

Commit

Permalink
Blob sidecar signatures: Remove DOMAIN_BLOB_SIDECAR
Browse files Browse the repository at this point in the history
The constant was removed from consensus-specs in v1.4.0-beta.5.
Blob sidecar signing was actually replaced in v1.4.0-beta.4.
  • Loading branch information
weekday-grandine-io committed Aug 8, 2024
1 parent 903869e commit 85b7917
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 14 deletions.
7 changes: 0 additions & 7 deletions http_api/src/full_config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ use types::{
bellatrix::primitives::Gas,
capella::consts::DOMAIN_BLS_TO_EXECUTION_CHANGE,
config::Config,
deneb::consts::DOMAIN_BLOB_SIDECAR,
phase0::{
consts::{
AttestationSubnetCount, DepositContractTreeDepth, JustificationBitsLength,
Expand Down Expand Up @@ -146,9 +145,6 @@ pub struct FullConfig {

// TODO(feature/deneb): Add constants from the Polynomial Commitments specification if needed.

// Deneb domain types
domain_blob_sidecar: DomainType,

// Builder constants
#[serde(with = "serde_utils::string_or_native")]
builder_proposal_delay_tolerance: u64,
Expand Down Expand Up @@ -232,9 +228,6 @@ impl FullConfig {
// Capella domain types
domain_bls_to_execution_change: DOMAIN_BLS_TO_EXECUTION_CHANGE,

// Deneb domain types
domain_blob_sidecar: DOMAIN_BLOB_SIDECAR,

// Builder constants
builder_proposal_delay_tolerance: BUILDER_PROPOSAL_DELAY_TOLERANCE,
domain_application_builder: DOMAIN_APPLICATION_BUILDER,
Expand Down
6 changes: 0 additions & 6 deletions types/src/deneb/consts.rs
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
use ethereum_types::H32;
use hex_literal::hex;
use typenum::{U32, U6};

use crate::phase0::primitives::DomainType;

// TODO(feature/deneb): Remove `DOMAIN_BLOB_SIDECAR` and everything that uses it.
// Blob sidecars are no longer signed starting with v1.4.0-beta.5.
pub const DOMAIN_BLOB_SIDECAR: DomainType = H32(hex!("0b000000"));
pub const VERSIONED_HASH_VERSION_KZG: &[u8] = &hex!("01");

// TODO(feature/deneb): Can `BlobSidecarSubnetCount` be a `const`?
Expand Down

0 comments on commit 85b7917

Please sign in to comment.