Warning when alternative stack size is not big enough #2154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…application's size settings to avoid information leakage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Gramine needs to reserve memory for xstate, sigframe, restorer's address in sigaltstack, cause size of sigaltstack should be large enough, thus I suggest size should at least
libos_xstate_size() + sizeof(struct sigframe) + 8 /* restorer address */+MINSIGSTKSZ, and warning when not big enough to help developer adjust.In the warning message, we should not report application's size settings to avoid information leakage.
See details in #2153
How to test this PR?
sigaltstack01 test case is helpful.
This change is