-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compiler): Write universal exports on linked module #2234
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good just two small questions.
I was testing with this locally and I think we changed the behaviour of the start function.
when compiled with We also get similar behaviour with |
@spotandjake Good catch. I restored the old behavior. We should maybe consider a warning for reserved export names, but that's not for this PR. |
I just tried this again the
we seem to hit a It might also make sense to add regression tests for both the I did some independent investigation on this and the problem is |
In #2104, the
write_universal_exports
function was previously called after linking, but I forgot to reinstate it. This restores that behavior.I deleted some tests because they were testing old behavior that was valid for the intermediate (object) wasm files but are no longer valid in the output of final wasm modules.