Test cases fail on go 1.5.1. This commit fixes some test case bugs. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that raise a lot of false positive fails. Test cases still fail, but with a lot less noise. See: #8
This involved an absolutely massive refactor that completely changed the interface. Things should be much more robust now.
|
Hey @denquixote Take a look at my branch. I got all the tests to pass (but basically by totally rewriting them along with most of the library) |
Conflicts: bcast_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test cases fail on go 1.5.1. This commit fixes some test case bugs, that raise a lot of false positive fails. Test cases still fail, but with a lot less noise.
I have run
go test -race, which results in a ton of warnings from both go 1.4.2 and 1.5.2. I have elimintated the race warning hoping the test fails were just test bugs. The tests still fail. Less dramatically, though. ;)