Pretty Encoding #32
Open
Pretty Encoding #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any encoders with the same indent share a cache. Only one assignment is made on depth change. `space` is equivalent to the third argument of [javascript's JSON.stringify](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/stringify)
|
You are using _ENV... is your changes breaks the Lua 5.1 compat ? |
|
Hah right, forgot to write the compat. I'll get on that |
|
Can't you just use a local table items instead of separated variables in _ENV ? for sample local config
...
-builder[i] = start_array
+builder[i] = config.start_array
...
- if type(space) ~= "string" or space == "" then _ENV = basic else
+ if type(space) ~= "string" or space == "" then config = basic elseand just avoid to use _ENV and ugly compat ? |
tst2005
reviewed
Aug 7, 2019
Turns out using the environment has zero performance benefit in any version of lua, so it just serves to make the code less readable
This brings the interface more in line with the rest of the library
|
This doesn't really do anything for consumers, however it is valuable for ensuring variables are made local
|
The string escape pattern is used in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #11
This is my shot at an efficient pretty encoding facility. I'm happy to implement any changes that could improve performance.
cacheargument, avoiding recreation of indent strings. This will consume memory (that will be released with the encoder), however the footprint is minimalspaceis equivalent to the third argument of javascript's JSON.stringify