[fix] Persist chart legend filters #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2Steaks
commented
Nov 16, 2023
|
|
||
| export const useOptions = ({ plot, theme, width }: CreateOptionsProps): Options => { | ||
| const [series, setSeries] = useState<Series[]>(plot.series) | ||
| const newPlot = { ...plot, series: mergeSeries(plot.series, series) } |
There was a problem hiding this comment.
@szkiba this might be overkill, is it possible for plot.series to change over time?
There was a problem hiding this comment.
I have no idea (uPlot documentation is a little bit limited)
szkiba
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes an issue where uPlot is losing it's state every render, in this case it relates to series that are being shown/hidden.
Why?
Every time fresh data is streamed into the application it is overwriting the series data, along with their options to show/hide
Checklist
go run mage.go lint) and all checks pass.go run mage.go test) and all tests pass.