Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Update chart when no data is available #88

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

2Steaks
Copy link
Collaborator

@2Steaks 2Steaks commented Nov 8, 2023

Closes https://github.com/grafana/k6-cloud/issues/1743

What?

  • Update builds
  • Add no data overlay to Chart components
  • Update ui mobile nav layout

Why?

The charts looked strange when no data was available

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (go run mage.go lint) and all checks pass.
  • I have run tests locally (go run mage.go test) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.
Screenshot 2023-11-08 at 15 32 03 Screenshot 2023-11-08 at 15 32 31 Screenshot 2023-11-08 at 15 32 44

- Update builds
- Add no data overlay to Chart components
- Update ui mobile nav layout
@2Steaks 2Steaks requested a review from szkiba November 8, 2023 15:35
@2Steaks 2Steaks self-assigned this Nov 8, 2023
Copy link
Collaborator

@szkiba szkiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you

@2Steaks 2Steaks merged commit fd62206 into master Nov 10, 2023
9 checks passed
@szkiba szkiba deleted the fix/update-chart-no-data branch June 7, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants