[feat] Add vanilla extract and restyle UI #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add license headers - Optimise colours for charts
- optimise Section panels
szkiba
reviewed
Nov 6, 2023
# Conflicts: # dashboard/assets/packages/report/vite.config.ts
- Remove test date from Charts - Update font sizes
2Steaks
commented
Nov 7, 2023
Comment on lines
+14
to
+22
| const dateFormats = [ | ||
| [3600 * 24 * 365, null, null, null, null, null, null, null, 1], | ||
| [3600 * 24 * 28, null, null, null, null, null, null, null, 1], | ||
| [3600 * 24, null, null, null, null, null, null, null, 1], | ||
| [3600, "{HH}", null, null, null, null, null, null, 1], | ||
| [60, "{HH}:{mm}", null, null, null, null, null, null, 1], | ||
| [1, ":{ss}", null, null, null, null, null, null, 1], | ||
| [0.001, ":{ss}.{fff}", null, null, null, null, null, null, 1] | ||
| ] |
There was a problem hiding this comment.
@szkiba I've messed around with these formats to remove the date, could you take a look at this and confirm whether it's okay?
- Fix grid gap so that it scales below full width on smaller screens - Add x axis scrolling for tables that are too wide
szkiba
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR updates the UI for the report package. Included with these changes are the use of css-in-js tool vanilla-extract and removal of bootstrap css
Why?
We want a well designed, print friendly, yet interactive view for the report page.
Checklist
go run mage.go lint) and all checks pass.go run mage.go test) and all tests pass.Before
After
@szkiba please let me know if the design is too basic.