Add common provider headers to cloud-provider-client #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
Duologic
requested changes
Oct 2, 2024
Co-authored-by: Jeroen Op 't Eynde <[email protected]>
|
@Duologic changes applied! |
Duologic
approved these changes
Oct 2, 2024
tristanburgess
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds provider headers the cloud-provider-client. This are basically:
Grafana-Terraform-Provider: true if request coming from provider, allows us in the API to understand a request comes from the providerGrafana-Terraform-Provider-Version: contains version of provider, might be useful to propagate it through context and log it to debug provider issuesAlso, once we have this, we can identify from which client a request is coming from, and then, store the "provenance" of a resource. Using here the same concept SLO uses https://github.com/grafana/slo/blob/346637b4ce113db1bc910f46fc397c72943e3426/pkg/api/slo.go#L410, which sounds just right.