Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Connections API client paths #1827

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

fridgepoet
Copy link
Member

@fridgepoet fridgepoet commented Oct 1, 2024

This PR modifies the paths for the Connections API client used to create metrics endpoint scrape jobs.
This PR also removes the Name field from the JSON request body to Connections API: the "Name" of the job is in the request path.

The beginning of the Connections API is being designed here.

@fridgepoet fridgepoet changed the title Update connections client paths Update Connections API client paths Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@fridgepoet fridgepoet marked this pull request as ready for review October 2, 2024 14:38
@fridgepoet fridgepoet requested a review from a team as a code owner October 2, 2024 14:38
@fridgepoet fridgepoet requested review from matthewnolf and removed request for a team October 2, 2024 14:38
@fridgepoet fridgepoet merged commit 48d3f35 into metrics-endpoint Oct 3, 2024
19 of 26 checks passed
@fridgepoet fridgepoet deleted the shirley/update-paths branch October 3, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants