-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for setting up cloud provider provider section #1816
Merged
thepalbi
merged 8 commits into
tf-cloud-provider-aws-app
from
pablo/adapt-docs-generator
Sep 30, 2024
Merged
Add docs for setting up cloud provider provider section #1816
thepalbi
merged 8 commits into
tf-cloud-provider-aws-app
from
pablo/adapt-docs-generator
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
thepalbi
changed the title
pablo/adapt docs generator
Add docs for setting up cloud provider provider section
Sep 26, 2024
tristanburgess
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts the docs generator template to include instructions on how to setup the Cloud Provider terraoform provider section. It instructs how to create the api token and correct hostname.
For setting up the hostname, the UI is super misleading as the cluserSlug is not shown but rather something like friendly names:
The easiest solution is call Grafana's API with the same token the user has to create, as follows:
Also, adjusts the examples so that they are the easiest possible to read.
Solves https://github.com/grafana/grafana-csp-app/issues/140