Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: LBAC for datasources #1777

Closed

Conversation

eleijonmarck
Copy link
Contributor

@eleijonmarck eleijonmarck commented Aug 23, 2024

so far:
updated swagger doc and swagger definitions in LBAC for datasources
https://github.com/grafana/grafana-enterprise/pull/7117
grafana/grafana#92594

implement / todo

  • read ✅
  • create
  • update
  • delete

Functionality of the resourceLBACRuleItem

Next steps for the LBAC for datasources would be to have:

  • users
  • service accounts

thought process currently

there is no ID for the json field teamHttpHeaders

  • so the state is only “stored” in the datasource as a whole, therefore leaning on copying the data_source_config resource more
    this is a resource that will be heavily used
  • i would like to have the internal state for terraform (some customers create about 500 rules and more), which clogs the datasource, i would like to copy the setup from grafana_data_source_permission_item for this. as it suits well for how we would like to setup this resource

run tests via

GRAFANA_VERSION=11.1.0 
GRAFANA_URL=http://localhost:3000 
GRAFANA_AUTH=admin:admin 
TESTARGS="-run TestAccDataSourceLBAC_inOrg" make testacc-enterprise

The teamHttpHeaders resource is a datasource json field.

epic

basically this introduced a way to add/update a datasource json field
lbac-api

here is the doc for it. https://grafana.com/docs/grafana/latest/administration/data-source-management/teamlbac/

Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@eleijonmarck
Copy link
Contributor Author

closing in favor of: #1797

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant