Alerting Rule Group: Support colon in title (#1625)

Will backport this one to v2 once this is merged

internal/common/resource.go

@@ -106,7 +106,7 @@ func (r *Resource) ImportExample() string {
 			fieldTemplates[i] = fmt.Sprintf("{{ %s }}", fields[i].Name)
 		}
 		return fmt.Sprintf(`terraform import %s.name %q
-`, r.Name, strings.Join(fieldTemplates, defaultSeparator))
+`, r.Name, strings.Join(fieldTemplates, ResourceIDSeparator))
 	}
 
 	id := r.IDType

internal/common/resource_id.go

@@ -10,7 +10,7 @@ import (
 type ResourceIDFieldType string
 
 const (
-	defaultSeparator          = ":"
+	ResourceIDSeparator       = ":"
 	ResourceIDFieldTypeInt    = ResourceIDFieldType("int")
 	ResourceIDFieldTypeString = ResourceIDFieldType("string")
 )
@@ -104,7 +104,7 @@ func (id *ResourceID) Make(parts ...any) string {
 		}
 	}
 
-	return strings.Join(stringParts, defaultSeparator)
+	return strings.Join(stringParts, ResourceIDSeparator)
 }
 
 // Single parses a resource ID into a single value
@@ -141,7 +141,7 @@ func (id *ResourceID) Split(resourceID string) ([]any, error) {
 // Split parses a resource ID into its parts
 // The parts will be cast to the expected types
 func split(resourceID string, expectedFields []ResourceIDField) ([]any, error) {
-	parts := strings.Split(resourceID, defaultSeparator)
+	parts := strings.Split(resourceID, ResourceIDSeparator)
 	if len(parts) == len(expectedFields) {
 		partsAsAny := make([]any, len(parts))
 		for i, part := range parts {
@@ -165,5 +165,5 @@ func split(resourceID string, expectedFields []ResourceIDField) ([]any, error) {
 	for i, f := range expectedFields {
 		expectedFieldNames[i] = f.Name
 	}
-	return nil, fmt.Errorf("id %q does not match expected format. Should be in the format: %s", resourceID, strings.Join(expectedFieldNames, defaultSeparator))
+	return nil, fmt.Errorf("id %q does not match expected format. Should be in the format: %s", resourceID, strings.Join(expectedFieldNames, ResourceIDSeparator))
 }

internal/resources/grafana/resource_alerting_rule_group.go

@@ -299,11 +299,10 @@ func listRuleGroups(ctx context.Context, client *goapi.GrafanaHTTPAPI, data *Lis
 func readAlertRuleGroup(ctx context.Context, data *schema.ResourceData, meta interface{}) diag.Diagnostics {
 	client, orgID, idWithoutOrg := OAPIClientFromExistingOrgResource(meta, data.Id())
 
-	split, err := resourceRuleGroupID.Split(idWithoutOrg)
-	if err != nil {
-		return diag.FromErr(err)
+	folderUID, title, found := strings.Cut(idWithoutOrg, common.ResourceIDSeparator)
+	if !found {
+		return diag.Errorf("invalid ID %q", idWithoutOrg)
 	}
-	folderUID, title := split[0].(string), split[1].(string)
 
 	resp, err := client.Provisioning.GetAlertRuleGroup(title, folderUID)
 	if err, shouldReturn := common.CheckReadError("rule group", data, err); shouldReturn {
@@ -427,11 +426,11 @@ func putAlertRuleGroup(ctx context.Context, data *schema.ResourceData, meta inte
 func deleteAlertRuleGroup(ctx context.Context, data *schema.ResourceData, meta interface{}) diag.Diagnostics {
 	client, _, idWithoutOrg := OAPIClientFromExistingOrgResource(meta, data.Id())
 
-	split, err := resourceRuleGroupID.Split(idWithoutOrg)
-	if err != nil {
-		return diag.FromErr(err)
+	folderUID, title, found := strings.Cut(idWithoutOrg, common.ResourceIDSeparator)
+	if !found {
+		return diag.Errorf("invalid ID %q", idWithoutOrg)
 	}
-	folderUID, title := split[0].(string), split[1].(string)
+
 	// TODO use DeleteAlertRuleGroup method instead (available since Grafana 11)
 	resp, err := client.Provisioning.GetAlertRuleGroup(title, folderUID)
 	if err != nil {

internal/resources/grafana/resource_alerting_rule_group_test.go

@@ -243,7 +243,7 @@ func TestAccAlertRule_inOrg(t *testing.T) {
 
 	var group models.AlertRuleGroup
 	var org models.OrgDetailsDTO
-	name := acctest.RandString(10)
+	name := "test:" + acctest.RandString(10)
 
 	resource.ParallelTest(t, resource.TestCase{
 		ProtoV5ProviderFactories: testutils.ProtoV5ProviderFactories,