Add doc for max_span_attr_byte and restructure troubleshoot doc #4551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knylander-grafana
requested review from
joe-elliott,
mdisibio,
mapno,
yvrhdn,
zalegrala,
electron0zero,
ie-pham,
stoewer and
javiermolinar
as code owners
|
This PR must be merged before a backport PR will be created. |
knylander-grafana
changed the title
docs/sources/tempo/troubleshooting/querying/too-many-jobs-in-queue.md
Outdated
Show resolved
Hide resolved
docs/sources/tempo/troubleshooting/querying/long-running-traces.md
Outdated
Show resolved
Hide resolved
jdbaldry
reviewed
Jan 15, 2025
There was a problem hiding this comment.
I've only really checked the aliases which work to redirect all the pre-patch locations to the post-patch locations.
Can we add a comments for all the old aliases with the full URL path they are intended to redirect so it's easier for a future reviewer to check?
joe-elliott
approved these changes
Jan 15, 2025
Co-authored-by: Jack Baldry <[email protected]>
I've added URL comments for all of the pages in the troubleshooting section. |
Fix {{% to {{<
docs/sources/tempo/troubleshooting/querying/too-many-jobs-in-queue.md
Outdated
Show resolved
Hide resolved
docs/sources/tempo/troubleshooting/querying/long-running-traces.md
Outdated
Show resolved
Hide resolved
docs/sources/tempo/troubleshooting/querying/too-many-jobs-in-queue.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Clayton Cornell <[email protected]>
clayton-cornell
approved these changes
Jan 15, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
Co-authored-by: Jack Baldry <[email protected]> Co-authored-by: Clayton Cornell <[email protected]> (cherry picked from commit e20401c)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds doc for
max_span_attr_byteand restructures the troubleshooting section.Which issue(s) this PR fixes:
Part of https://github.com/grafana/tempo-squad/issues/533
Part of restructure doc work: https://github.com/grafana/tempo-squad/issues/468
Doc for #4335
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]