Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some docs about deploy tempo Gateway and use it with Grafana #3135

Merged
merged 27 commits into from
Nov 29, 2023
Merged

Add some docs about deploy tempo Gateway and use it with Grafana #3135

merged 27 commits into from
Nov 29, 2023

Conversation

rubenvp8510
Copy link
Contributor

What this PR does:

Add some docs about deploy tempo Gateway and use it with Grafana

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@knylander-grafana knylander-grafana added the type/docs Improvements or additions to documentation label Nov 13, 2023
knylander-grafana
knylander-grafana requested changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding documentation! I've made some suggested changes. See what you think.

@rubenvp8510
Copy link
Contributor Author

Thank you for adding documentation! I've made some suggested changes. See what you think.

Thanks for all your suggestions. I also fixed a couple of more things.

@rubenvp8510
Copy link
Contributor Author

Ready for another review

knylander-grafana
knylander-grafana requested changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your updates looks mostly good. However, one small change to be consistent with the way Grafana references data sources. Data sources are lowercase and two words.
image

I've made suggested changes throughout to update the PR. Otherwise, things look great!

@knylander-grafana knylander-grafana self-assigned this Nov 28, 2023
rubenvp8510 and others added 9 commits November 28, 2023 16:40
@rubenvp8510 @knylander-grafana
Update docs/sources/tempo/operations/grafana_datasource.md
bd10aaf 
Co-authored-by: Kim Nylander <[email protected]>
@rubenvp8510 @knylander-grafana
Update docs/sources/tempo/operations/grafana_datasource.md
e654444 
Co-authored-by: Kim Nylander <[email protected]>
@rubenvp8510 @knylander-grafana
Update docs/sources/tempo/operations/grafana_datasource.md
c1fce10 
Co-authored-by: Kim Nylander <[email protected]>
@rubenvp8510 @knylander-grafana
Update docs/sources/tempo/operations/grafana_datasource.md
5b53b97 
Co-authored-by: Kim Nylander <[email protected]>
@rubenvp8510 @knylander-grafana
Update docs/sources/tempo/operations/grafana_datasource.md
7f9467a 
Co-authored-by: Kim Nylander <[email protected]>
@rubenvp8510 @knylander-grafana
Update docs/sources/tempo/operations/grafana_datasource.md
910f404 
Co-authored-by: Kim Nylander <[email protected]>
@rubenvp8510 @knylander-grafana
Update docs/sources/tempo/operations/grafana_datasource.md
7d3f207 
Co-authored-by: Kim Nylander <[email protected]>
@rubenvp8510 @knylander-grafana
Update docs/sources/tempo/operations/grafana_datasource.md
123a03e 
Co-authored-by: Kim Nylander <[email protected]>
@rubenvp8510 @knylander-grafana
Update docs/sources/tempo/operations/grafana_datasource.md
9c9a631 
Co-authored-by: Kim Nylander <[email protected]>
@rubenvp8510
Copy link
Contributor Author

Thanks for all the suggestions. I've already accepted it

knylander-grafana
knylander-grafana approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Pleasure to do a PR review with you.

@knylander-grafana knylander-grafana merged commit c7b7ae0 into grafana:main Nov 29, 2023
14 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 29, 2023
@rubenvp8510 @grafana-delivery-bot
Add some docs about deploy tempo Gateway and use it with Grafana (#3135)
7f6c073 
* Add some docs about deploy tempo Gateway and use it with Grafana

Signed-off-by: Ruben Vargas <[email protected]>

* add title

Signed-off-by: Ruben Vargas <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* change frontend-query to query-frontend

Signed-off-by: Ruben Vargas <[email protected]>

* Rephrase the URL setting

Signed-off-by: Ruben Vargas <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Use Datasource in all the reference words

Signed-off-by: Ruben Vargas <[email protected]>

* More improvments0

Signed-off-by: Ruben Vargas <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

---------

Signed-off-by: Ruben Vargas <[email protected]>
Co-authored-by: Kim Nylander <[email protected]>
(cherry picked from commit c7b7ae0)
@github-actions github-actions bot mentioned this pull request Nov 29, 2023
Merged
3 tasks
knylander-grafana pushed a commit that referenced this pull request Dec 7, 2023
@github-actions @rubenvp8510
Add some docs about deploy tempo Gateway and use it with Grafana (#3135…
dfb45e7 
…) (#3189)

* Add some docs about deploy tempo Gateway and use it with Grafana

Signed-off-by: Ruben Vargas <[email protected]>

* add title

Signed-off-by: Ruben Vargas <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* change frontend-query to query-frontend

Signed-off-by: Ruben Vargas <[email protected]>

* Rephrase the URL setting

Signed-off-by: Ruben Vargas <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Use Datasource in all the reference words

Signed-off-by: Ruben Vargas <[email protected]>

* More improvments0

Signed-off-by: Ruben Vargas <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

Co-authored-by: Kim Nylander <[email protected]>

* Update docs/sources/tempo/operations/grafana_datasource.md

---------

Signed-off-by: Ruben Vargas <[email protected]>
Co-authored-by: Kim Nylander <[email protected]>
(cherry picked from commit c7b7ae0)

Co-authored-by: Ruben Vargas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knylander-grafana knylander-grafana knylander-grafana approved these changes

@jdbaldry jdbaldry Awaiting requested review from jdbaldry

@joe-elliott joe-elliott Awaiting requested review from joe-elliott joe-elliott is a code owner

@annanay25 annanay25 Awaiting requested review from annanay25

@mdisibio mdisibio Awaiting requested review from mdisibio mdisibio is a code owner

@mapno mapno Awaiting requested review from mapno mapno is a code owner

@yvrhdn yvrhdn Awaiting requested review from yvrhdn yvrhdn is a code owner

@zalegrala zalegrala Awaiting requested review from zalegrala zalegrala is a code owner

@electron0zero electron0zero Awaiting requested review from electron0zero electron0zero is a code owner

@ie-pham ie-pham Awaiting requested review from ie-pham ie-pham is a code owner

@stoewer stoewer Awaiting requested review from stoewer stoewer is a code owner

Assignees

@knylander-grafana knylander-grafana

Labels
backport release-v2.3 type/docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubenvp8510 @knylander-grafana