[DOC] Update definition for traces #3060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knylander-grafana
requested review from
jdbaldry,
joe-elliott,
annanay25,
mdisibio,
mapno,
yvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
knylander-grafana
added
type/docs
This was referenced Oct 24, 2023
Closed
…3061) * Use glossary lookups instead of duplicating that information Signed-off-by: Jack Baldry <[email protected]> * Fix `make-docs` script typo Signed-off-by: Jack Baldry <[email protected]> --------- Signed-off-by: Jack Baldry <[email protected]>
|
Closing this PR. The definition has been included in the website repo in glossary.yaml. this definition is now modular and will be used consistently across the site. |
|
I need to merge Jack's changes so I reopened this PR. @jdbaldry would you review? |
knylander-grafana
changed the title
3 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Nov 17, 2023
* Update definition for traces * [DOC] Use glossary lookups instead of duplicating that information (#3061) * Use glossary lookups instead of duplicating that information Signed-off-by: Jack Baldry <[email protected]> * Fix `make-docs` script typo Signed-off-by: Jack Baldry <[email protected]> --------- Signed-off-by: Jack Baldry <[email protected]> --------- Signed-off-by: Jack Baldry <[email protected]> Co-authored-by: Jack Baldry <[email protected]> (cherry picked from commit 44761ce)
knylander-grafana
added a commit
that referenced
this pull request
Nov 22, 2023
* Update definition for traces * [DOC] Use glossary lookups instead of duplicating that information (#3061) * Use glossary lookups instead of duplicating that information Signed-off-by: Jack Baldry <[email protected]> * Fix `make-docs` script typo Signed-off-by: Jack Baldry <[email protected]> --------- Signed-off-by: Jack Baldry <[email protected]> --------- Signed-off-by: Jack Baldry <[email protected]> Co-authored-by: Jack Baldry <[email protected]> (cherry picked from commit 44761ce) Co-authored-by: Kim Nylander <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Incorporates changes from PR #2694 (author never signed CLA)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]