Skip to content

Commit

Permalink
Remove some comments
Browse files Browse the repository at this point in the history
  • Loading branch information
zalegrala committed Oct 26, 2023
1 parent d0c3fdd commit c080db0
Showing 1 changed file with 3 additions and 20 deletions.
23 changes: 3 additions & 20 deletions tempodb/blocklist/poller.go
Original file line number Diff line number Diff line change
Expand Up @@ -300,33 +300,16 @@ func (p *Poller) pollTenantBlocks(
continue
}

// TODO: Review this hack to avoid polling for compacted blocks that we
// know about. But we need to poll this to ensure that we have the correct
// time. Probably.
// if v, ok := mm[blockID]; ok {
// chCompactedMeta <- &backend.CompactedBlockMeta{
// BlockMeta: *v,
// // CompactedTime: time.Now(),
// }
// continue
// }
// TODO: Review the ability to avoid polling for compacted blocks that we
// know about. We need to know the compacted time, but perhaps there is
// another way to get that, like the object creation time.

newBlockIDs = append(newBlockIDs, blockID)

// TODO: for the compacted block IDs that we don't know about, we should
// poll directly rather than go through the pollBlock() function. This
// would avoid the 404 on the meta.json and go directly to the
// meta.compacted.json.
// compactedBlockMeta, err = p.compactor.CompactedBlockMeta(blockID, tenantID)
// if err != nil {
// // log
// level.Error(p.logger).Log("msg", "failed to poll compacted block", "tenant", tenantID, "blockID", blockID, "err", err)
// continue
// }
// if compactedBlockMeta != nil {
// newCompactedBlocklist = append(newCompactedBlocklist, compactedBlockMeta)
// }

}
learnSpan.Finish()

Expand Down

0 comments on commit c080db0

Please sign in to comment.