Remove kube-rbac-proxy #1099
Remove kube-rbac-proxy #1099
Conversation
rubenvp8510
force-pushed
the
remove_metrics_proxy
branch
from
bd1abbb to
3739c47
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1099 +/- ##
==========================================
- Coverage 58.64% 58.59% -0.06%
==========================================
Files 113 113
Lines 10145 10157 +12
==========================================
+ Hits 5950 5951 +1
- Misses 3892 3902 +10
- Partials 303 304 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rubenvp8510
force-pushed
the
remove_metrics_proxy
branch
12 times, most recently
from
f61dcb4 to
f900aa1
Compare
Signed-off-by: Ruben Vargas <[email protected]>
rubenvp8510
force-pushed
the
remove_metrics_proxy
branch
from
f900aa1 to
b3d60ea
Compare
| @@ -0,0 +1,16 @@ | |||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | |||
| change_type: deprecation | |||
There was a problem hiding this comment.
Does this change affect the end user? Do end users need to update the metric endpoint?
I think it's an internal change and transparent to the user, so I'd mark it as enhancement.
There was a problem hiding this comment.
It doesn't affect. it should be transparent
| @@ -4,7 +4,8 @@ distribution: community | |||
| health: | |||
| healthProbeBindAddress: :8081 | |||
| metrics: | |||
| bindAddress: 127.0.0.1:8080 | |||
| secure: true | |||
There was a problem hiding this comment.
If secure is true, I assume we also need to set --metrics-tls-cert-file, is this set somewhere in the community version?
There was a problem hiding this comment.
When you don't specific certs those will be self-signed
Co-authored-by: Andreas Gerstmayr <[email protected]>
Fixes #1094