Do not set --prometheus.query.namespace if field is empty #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasgerstmayr
force-pushed
the
remove-red-namespace-default
branch
from
64f9af4 to
f5bc31f
Compare
Do not set `--prometheus.query.namespace` if `.spec.template.queryFrontend.jaegerQuery.monitorTab.redMetricsNamespace` is empty. Signed-off-by: Andreas Gerstmayr <[email protected]>
andreasgerstmayr
force-pushed
the
remove-red-namespace-default
branch
from
f5bc31f to
49428e8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1096 +/- ##
==========================================
+ Coverage 67.91% 67.93% +0.01%
==========================================
Files 110 110
Lines 8728 8731 +3
==========================================
+ Hits 5928 5931 +3
Misses 2503 2503
Partials 297 297
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pavolloffay
approved these changes
Dec 2, 2024
frzifus
approved these changes
Dec 2, 2024
…lt traces_span_metrics namespace Signed-off-by: Andreas Gerstmayr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not set
--prometheus.query.namespaceif.spec.template.queryFrontend.jaegerQuery.monitorTab.redMetricsNamespaceis empty.