fix: filter by probe on data transferred and assertions panels for browser and scripted checks #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VikaCep
changed the title
VikaCep
changed the title
|
This is great but I've noticed there are some other panels that also aren't taking into account the probe filter so think we should add the probe filter to them, too: Scripted
Browser |
For scripted: - Uptime - Assertions - Results by URL For browser: - Uptime - FCP, LCP, TTFB, CLS, FID, INP - Page load p75 - CLS p75 - Input response time p75 - Metrics by URL - Assertions
|
Great catch, I've updated all panels accordingly to take the probe into account: Scripted checks dashboard filtering by one probe location:
Browser checks dashboard filtering by one probe location: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1029
The data transferred and assertions panels in the Browser and Scripted dashboards aren't taking into account filtered probes. This PR fixes that.
Since in dev we only have one running probe location, I've validated the queries work as expected using Explorer in my prod account:
Before setting the probe filter (as it currently works in the dashboards):
Data sent chart:
Data received chart:
Success rate chart:
After setting the probe filter (after this PR implementation):
Data sent chart:
Data received chart:
Success rate chart:
