feat: print workflow uri immediately even when using --wait flag #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… using --wait flag
dblinkhorn
changed the title
zerok
requested changes
Jan 2, 2025
| uri, output := a.outputWithURI(cmdOutput) | ||
| uri, out, scanErr := a.outputWithURI(stdoutPipe) | ||
| if scanErr != nil { | ||
| return uri, out, scanErr |
There was a problem hiding this comment.
Please garbage collect the cmd and the pipe to avoid zombie processes 🙂
There was a problem hiding this comment.
Thanks for pointing this out. I added a defer function for cleanup. Also, please feel free to nitpick all my PRs since I am very new to Go.
There was a problem hiding this comment.
Will do :) Regarding the defer: This is now also called in the happy path. IMO it should be enough to just do
_ = stdoutPipe.Close()
_ = cmd.Wait()
in the scanErr case and that's it 🙂
| if len(matches) != 2 { | ||
| a.logger.Warn("Couldn't find workflow name in output - can't construct URI for launched workflow") | ||
| return "", output | ||
| matches := nameRe.FindStringSubmatch(line) |
There was a problem hiding this comment.
Even the matching can be skipped if uri is already set, right?
There was a problem hiding this comment.
Updated the flow to address this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.