feat(check-for-non-releasable-actions): find reusable workflows too #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainlane
force-pushed
the
iainlane/find-missing-reusable-workflows
branch
7 times, most recently
from
63ee73c to
6251c8c
Compare
We need to release reusable workflows just like we do for Actions. The current linter didn't check for that, so it's added here. This required an extra library to parse the YAML, and GitHub scripts can't install new dependencies, so it's broken out to a small `internal/` composite action which can. Now we have two Typescript actions, it made sense to centralise some of the setup. We have a shared `eslint` config now, and `bun` workspaces for each of the modules so they can cross-reference.
iainlane
force-pushed
the
iainlane/find-missing-reusable-workflows
branch
from
6251c8c to
c7f4ffd
Compare
|
To be able to finish this PR, I need to figure out how to get |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to release reusable workflows just like we do for Actions. The current linter didn't check for that, so it's added here. This required an extra library to parse the YAML, and GitHub scripts can't install new dependencies, so it's broken out to a small
internal/composite action which can.Now we have two Typescript actions, it made sense to centralise some of the setup. We have a shared
eslintconfig now, andbunworkspaces for each of the modules so they can cross-reference.