Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add validate-policy-bot-action #497

Merged
merged 6 commits into from
Nov 11, 2024
Merged

Conversation

Elfo404
Copy link
Contributor

@Elfo404 Elfo404 commented Oct 23, 2024

Related to #478 (does not fix it, see #497 (comment))

adds a validate-policy-bot-action that can be used to validate a Policy Bot config file.

Open points:
We should probably distribute the policy bot generator from deployment_tools so that other repos can use it without copy-pasting it.
If we do so, we could also include drift detection in this action, and if we do so, then this action should run also on any other workflow file change.

@Elfo404 Elfo404 force-pushed the gio/feat/validate-policy-bot branch 2 times, most recently from cb8392e to 569334f Compare October 23, 2024 10:01
@Elfo404 Elfo404 force-pushed the gio/feat/validate-policy-bot branch from 569334f to f789601 Compare October 23, 2024 10:08
@Elfo404 Elfo404 marked this pull request as ready for review October 23, 2024 10:59
@Elfo404 Elfo404 requested a review from a team as a code owner October 23, 2024 10:59
@iainlane
Copy link
Member

I would move that out to a public repo (probably its own one?), that'd be great

@iainlane
Copy link
Member

iainlane commented Nov 4, 2024

One thing I just realised. Since we use merge queues in this repository the policy bot isn't going to be very helpful. We should still provide a shared workflow for folks that don't use them, but I'm not sure about the generated one in this PR. 🤔

palantir/policy-bot#800

@Elfo404
Copy link
Contributor Author

Elfo404 commented Nov 5, 2024

@iainlane Removed the check for this repo and updated the README of the action. mind a sanity check?

@Elfo404 Elfo404 requested a review from iainlane November 5, 2024 12:34
@Elfo404 Elfo404 added this pull request to the merge queue Nov 11, 2024
Merged via the queue into main with commit 29ab6fb Nov 11, 2024
7 checks passed
@Elfo404 Elfo404 deleted the gio/feat/validate-policy-bot branch November 11, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants