SceneCSSGridLayout: Add support for dragging and dropping panels #993
Conversation
kaydelaney
added
minor
| parentState?: SceneCSSGridItemPlacement; | ||
| } | ||
|
|
||
| export class SceneCSSGridItem extends SceneObjectBase<SceneCSSGridItemState> { |
There was a problem hiding this comment.
I understand doing pocs here (if you need to make changes to VizPanelRenderer esp),
just be aware we have a special class in core for this CSS grid items, https://github.com/grafana/grafana/blob/main/public/app/features/dashboard-scene/scene/layout-responsive-grid/ResponsiveGridItem.tsx#L13
There was a problem hiding this comment.
Oh this wasn't a POC, I just factored it out from SceneCSSGridLayout
There was a problem hiding this comment.
I understand, just know we are not using it dashboards.
I think a challenge with this work is what logic needs live in scenes vs the core repo implementation (and the ResponsiveGridLayoutManager)
|
Tried to test it with the css grid demo but just get an empty page |
|
@torkelo The css grid demo should work now - made some fixes. |
|
@kaydelaney works really well! I am not sure it helps or not but might be useful to go directly from this and explore how moving a panel between layouts would work (as as an early exploratory poc/test, to understand the problem etc) . |
|
and by "between layouts" i mean between two separate CSS grids in this case (moving between CSS grid and the default grid is a separate problem, one we might have to solve as well) |
There's a lot of code here but the gist of it is enables support for dragging and dropping panels in the responsive grid layout (when paired with the PR linked below)
Let me know if there are any questions or parts of the code that could use further explanation.
Related: grafana/grafana#97495