AdHocFiltersCombobox: Prevent updating combobox options when input type changed during fetch #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergej-Vlasov
added
type/bug
Sergej-Vlasov
force-pushed
the
serge/fix-combobox-options-fetch-concurency
branch
from
26889bf to
39b7462
Compare
dprokop
requested review from
a team and
kaydelaney
and removed request for
a team
dprokop
reviewed
Nov 29, 2024
Comment on lines
+236
to
+237
| // if input type changed before fetch completed then abort updating options | ||
| // this can cause race condition and return incorrect options when input type changed |
There was a problem hiding this comment.
As we discussed on a call:
Outdated options fetches are not cancelled and therefore can have concurrency issues - older more expensive calls (values) can finish later than newer faster calls (operators) and this results in values replacing operators in dropdown options as example. Ideal solution requires making those calls cancellable but while this is in progress (due to more effort) I introduced a quick fix to prevent this bug in most cases
dprokop
approved these changes
Nov 29, 2024
Sergej-Vlasov
deleted the
serge/fix-combobox-options-fetch-concurency
branch
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes concurrency issue during options update in ad hoc filters combobox.
📦 Published PR as canary version:
5.28.1--canary.982.12087080743.0✨ Test out this PR locally via: