Utils: Spread objects in cloneSceneObjectState

[kaydelaney]

Fixes an issue where if a panel was duplicated, both the original panel and duplicated panel's queries state (in SceneQueryRunner) referred to the same object in memory, meaning when the duplicate query was changed, so was the original.

Thread: https://raintank-corp.slack.com/archives/C03KVDHTWAH/p1730897481961219

📦 Published PR as canary version: 5.25.1--canary.967.11837797508.0

✨ Test out this PR locally via:

npm install @grafana/[email protected]
npm install @grafana/[email protected]
# or 
yarn add @grafana/[email protected]
yarn add @grafana/[email protected]

[torkelo]

where do we mutate the queries object?

[kaydelaney]

@torkelo It might be something strange some datasources do - could only reproduce with graphite/Mock datasource but not prometheus for example. I'll check.

[kaydelaney]

Okay so looking into a bit more, at least in the case of Graphite, I think what's happening is it's taking the target that's passed to it and ultimately manipulating that when the query is modified via the graphite query editor.

https://github.com/grafana/grafana/blob/6abe99efd64b8867112d9d9c74971d96840ce32d/public/app/plugins/datasource/graphite/state/context.tsx#L91

Changing the above to target: { ...query } also seems to fix the issue, but other data sources also seem to make the same mistake, so it might be worthwhile "fixing" in scenes just the same.

[dprokop]

This is going to be problematic for properties that are Array. The individual array values will be spread as properties on the state.

[kaydelaney]

Ah, good catch. Do you think something like this would be okay?

Suggested change

	} else if (typeof child === 'object') {
	newArray.push({ ...child });
	} else if (typeof child === 'object' && !Array.isArray(child)) {
	newArray.push({ ...child });

[torkelo]

yea, that could work.

But if it's just graphite maybe we can fix the mutation here: https://github.com/grafana/grafana/blob/6abe99efd64b8867112d9d9c74971d96840ce32d/public/app/plugins/datasource/graphite/state/store.ts#L53

(and elsewhere)

[leeoniya]

this bug was also reported for Google Cloud Monitoring datasource: grafana/grafana#97223 (comment)