Moving to rsync #938
Merged
Moving to rsync #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 15, 2024
…cause turbo can not pass arguments to single targets
jackw
reviewed
Oct 15, 2024
| }; | ||
|
|
||
| const presetsTheme = { | ||
| customCss: require.resolve('./src/css/custom.css'), |
There was a problem hiding this comment.
The css files might need an update too.
There was a problem hiding this comment.
Updated c736f89
jackw
reviewed
Oct 15, 2024
|
@dprokop I managed to fix the build issues related to cache by removing the single github actions caches manually
but I think the cache logic you are using in this workflow should be re-evaluated https://github.com/grafana/scenes/blob/main/.github/actions/yarn-nm-install/action.yml as it will most likely happen to other PRs. It also takes quite a while to store - e.g. https://github.com/grafana/scenes/actions/runs/11344746920/job/31550341163#step:12:1 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on: grafana/plugin-tools#1214 and https://github.com/grafana/grafana-developer-portal/pull/22
Switching to using rsync with delete option - to ensure that the GCS content equals the content of the build, up until now we just added new files but never deleted the old ones. Since it is a static site - it can lead to some weird old built pages still being available even when deleted from the source code. This PR cleans it up.
Starting as dry run
-nand will remove it before merge.Additional yak shaving changes:
Example runs:
Dev https://github.com/grafana/scenes/actions/runs/11343394573/job/31545849078
Prod - will run once merged
Remove dry run for dev
Remove dry run for prod