SceneQueryRunner: make some fields and methods protected #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #587 is quite a large change and introduces more concepts to scenes, so isn't easy to justify merging right now. As a workaround, I'd like to be able to subclass and override some methods of the SceneQueryRunner to implement some similar behaviour in a different library, but I need various fields and methods to be accessible to the subclass, which this PR does by making them protected rather than private. Note: I can _almost_ just completely copy/paste the class into my own code rather than extending it, but the [`getQueriesForVariables`] function looks for all _instances_ of SceneQueryRunner, which my copy/pasted class would not match (unlike a subclass, which should), so I think some ad-hoc variable support would break :( `getQueriesForVariables`: https://github.com/grafana/scenes/blob/07c5dc66746d36208cd121b938883db8ef2243f7/packages/scenes/src/variables/utils.ts#L88-L94
|
Closing, not needed now that #587 has been merged 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #587 is quite a large change and introduces more concepts to scenes, so isn't easy to justify merging right now. As a workaround, I'd like to be able to subclass and override some methods of the SceneQueryRunner to implement some similar behaviour in a different library, but I need various fields and methods to be accessible to the subclass, which this PR does by making them protected rather than private.
Note: I can almost just completely copy/paste the class into my own code rather than extending it, but the
getQueriesForVariablesfunction looks for all instances of SceneQueryRunner, which my copy/pasted class would not match (unlike a subclass, which should), so I think some ad-hoc variable support would break :(I'm hoping this is a less controversial change than #587 which will unblock me - let me know what you think!