Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SceneTimeRange: Set weekstart when evaluating time range #1007

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

torkelo
Copy link
Member

@torkelo torkelo commented Dec 17, 2024

So after testing #1002 in main it had some issues

mainly that the weekstart is only updated on scene time range activation, which only happens when the dashboard is mounted so if you change weekstart and go back to the dashboard the time range has not updated (even when you hit refresh on the time range picker).

With this change we update the system weekstart when we evaluate the time range (with a quick cache var so we do not always call setWeekStart).

There will still be a need for the user to manually hit refresh after updating time range (unless we in core call onRefresh after setting weekStart which we can do in the main repo PR)

📦 Published PR as canary version: 5.35.0--canary.1007.12374452740.0

✨ Test out this PR locally via:

npm install @grafana/[email protected]
npm install @grafana/[email protected]
# or 
yarn add @grafana/[email protected]
yarn add @grafana/[email protected]

@torkelo torkelo added minor Increment the minor version when merged release Create a release when this pr is merged labels Dec 17, 2024
@torkelo torkelo merged commit 76d9a3a into main Dec 18, 2024
5 checks passed
@torkelo torkelo deleted the fix-weekstart-again2 branch December 18, 2024 10:03
@scenes-repo-bot-access-token
Copy link

🚀 PR was released in v5.35.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged release Create a release when this pr is merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants