SceneTimeRange: Set weekstart when evaluating time range #1007
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So after testing #1002 in main it had some issues
mainly that the weekstart is only updated on scene time range activation, which only happens when the dashboard is mounted so if you change weekstart and go back to the dashboard the time range has not updated (even when you hit refresh on the time range picker).
With this change we update the system weekstart when we evaluate the time range (with a quick cache var so we do not always call setWeekStart).
There will still be a need for the user to manually hit refresh after updating time range (unless we in core call onRefresh after setting weekStart which we can do in the main repo PR)
📦 Published PR as canary version:
5.35.0--canary.1007.12374452740.0
✨ Test out this PR locally via: