Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrap groupBy single-select value in an array #1000

Merged
merged 6 commits into from
Dec 13, 2024
Merged

fix: wrap groupBy single-select value in an array #1000

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cf2cb04
fix: wrap single-select value in an array
joannaWebDev Dec 13, 2024
eb5e237
chore: prettier
joannaWebDev Dec 13, 2024
b18345b
feat: add label
joannaWebDev Dec 13, 2024
9d8f83b
feat: label here cannot be undefined
joannaWebDev Dec 13, 2024
803d2c1
feat: improve label undefined declaration
joannaWebDev Dec 13, 2024
cc1faff
chore: no comment
joannaWebDev Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/scenes/src/variables/groupby/GroupByVariable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,9 +340,9 @@ export function GroupByVariableRenderer({ model }: SceneComponentProps<MultiValu
}
return;
}
if (newValue?.value) {
if (newValue?.value && newValue?.label) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think you want this extra condition. label is optional

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to avoid the !
Screenshot 2024-12-13 at 11 23 24 AM

  }
        if (newValue?.value) {
          setUncommittedValue([newValue]);
          model.changeValueTo([newValue.value], [newValue.label!]);
        }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe something like:

        if (newValue?.value) {
          setUncommittedValue([newValue]);
          model.changeValueTo([newValue.value], newValue.label ? [newValue.label] : undefined);
        }

would work then

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

setUncommittedValue([newValue]);
model.changeValueTo(newValue.value, newValue.label);
model.changeValueTo([newValue.value], [newValue.label]);
}
}}
onOpenMenu={async () => {
Expand Down
Loading