Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(distributor): validate string table accesses #3818

Merged
merged 1 commit into from
Jan 6, 2025
Merged

fix(distributor): validate string table accesses #3818

merged 1 commit into from
Jan 6, 2025

Conversation

korniltsev
Copy link
Collaborator

No description provided.

@korniltsev korniltsev requested a review from a team as a code owner January 6, 2025 09:11
@korniltsev korniltsev added the type/bug Something isn't working label Jan 6, 2025
@korniltsev korniltsev mentioned this pull request Jan 6, 2025
Merged
simonswine
simonswine approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

At which point are we checking that StringTable[0] == ""? I can find it right now, but I pretty sure we do it...

@korniltsev korniltsev force-pushed the korniltsev/distributor_string_oob_fix branch from a0280b1 to d3fc4d2 Compare January 6, 2025 09:22
@korniltsev
Copy link
Collaborator Author

I've added a case for empty string just in case

@korniltsev korniltsev enabled auto-merge (squash) January 6, 2025 09:27
@korniltsev korniltsev force-pushed the korniltsev/distributor_string_oob_fix branch from d3fc4d2 to 92a114a Compare January 6, 2025 09:40
@korniltsev korniltsev merged commit b362e0e into main Jan 6, 2025
18 checks passed
@korniltsev korniltsev deleted the korniltsev/distributor_string_oob_fix branch January 6, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonswine simonswine simonswine approved these changes

Assignees
No one assigned
Labels
type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@korniltsev @simonswine