Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update make docs procedure #3802

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update make docs procedure #3802

wants to merge 2 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

To test the changes, run the following and browse to URL output by the script:

git fetch
git checkout origin/update-make-docs
cd docs
make docs

@github-actions github-actions bot requested a review from jdbaldry as a code owner December 23, 2024 07:06
@github-actions github-actions bot added the type/docs Improvements for doc docs. Used by Docs team for project management label Dec 23, 2024
@aleks-p
Copy link
Contributor

aleks-p commented Dec 27, 2024

@jdbaldry since this is created by the github actions bot, the workflows for the checks will not trigger

see #3767 (comment) for some context, you can probably re-use the solution there to work around this

@jdbaldry
Copy link
Member

jdbaldry commented Dec 27, 2024

Thanks for the information, definitely something I'll do in the new year :)

It's especially important for repositories like Pyroscope where I don't have write access to push to this repository's branches like the workflow token does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements for doc docs. Used by Docs team for project management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants