Skip to content

Commit

Permalink
renames UpstreamAddress to ServerAddress - I think this name is clearer
Browse files Browse the repository at this point in the history
  • Loading branch information
petethepig committed Jan 2, 2021
1 parent 37fbf26 commit 71c123a
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion pkg/agent/agent.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ func New(cfg *config.Config) *Agent {
activeProfiles: make(map[int]*ProfileSession),
u: remote.New(remote.RemoteConfig{
UpstreamThreads: cfg.Agent.UpstreamThreads,
UpstreamAddress: cfg.Agent.UpstreamAddress,
UpstreamAddress: cfg.Agent.ServerAddress,
UpstreamRequestTimeout: cfg.Agent.UpstreamRequestTimeout,
}),
}
Expand Down
4 changes: 2 additions & 2 deletions pkg/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ type Agent struct {
// AgentCMD []string
AgentSpyName string `desc:"name of the spy you want to use"` // TODO: add options
AgentPID int `def:"-1" desc:"pid of the process you want to spy on"`
UpstreamAddress string `def:"http://localhost:8080" desc:"address of the pyroscope server"`
ServerAddress string `def:"http://localhost:8080" desc:"address of the pyroscope server"`
UpstreamThreads int `def:"4"`
UpstreamRequestTimeout time.Duration `def:"10s"`
UNIXSocketPath string `def:"/var/run/pyroscope-agent.sock" desc:"path to a UNIX socket file"`
Expand Down Expand Up @@ -59,7 +59,7 @@ type Exec struct {
SpyName string `def:"auto"`
ApplicationName string `def:"" desc:"application name used when uploading profiling data"`
DetectSubprocesses bool `def:"true"`
UpstreamAddress string `def:"http://localhost:8080" desc:"address of the pyroscope server"`
ServerAddress string `def:"http://localhost:8080" desc:"address of the pyroscope server"`
UpstreamThreads int `def:"4" desc:"number of upload threads"`
UpstreamRequestTimeout time.Duration `def:"10s"`
NoLogging bool `def:"false" desc:"disables logging from pyroscope"`
Expand Down
2 changes: 1 addition & 1 deletion pkg/exec/cli.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ func Cli(cfg *config.Config, args []string) error {
return err
}
u := remote.New(remote.RemoteConfig{
UpstreamAddress: cfg.Exec.UpstreamAddress,
UpstreamAddress: cfg.Exec.ServerAddress,
UpstreamThreads: cfg.Exec.UpstreamThreads,
UpstreamRequestTimeout: cfg.Exec.UpstreamRequestTimeout,
})
Expand Down

0 comments on commit 71c123a

Please sign in to comment.