chore(v2): add some more safety checks

grafana · Jan 21, 2025 · 4c8cff6 · 4c8cff6
1 parent b14df27
commit 4c8cff6
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/experiment/metastore/compaction_raft_handler.go b/pkg/experiment/metastore/compaction_raft_handler.go
@@ -163,8 +163,8 @@ func (h *CompactionCommandHandler) UpdateCompactionPlan(
 
 	for _, job := range req.PlanUpdate.CompletedJobs {
 		compacted := job.GetCompactedBlocks()
-		if compacted == nil {
-			level.Error(h.logger).Log("msg", "compacted blocks are missing", "job", job.State.Name)
+		if compacted == nil || compacted.SourceBlocks == nil || len(compacted.NewBlocks) == 0 {
+			level.Warn(h.logger).Log("msg", "compacted blocks are missing; skipping", "job", job.State.Name)
 			continue
 		}
 		if err := h.tombstones.AddTombstones(tx, cmd, blockTombstonesForCompletedJob(job)); err != nil {