fix(flameql): allow slashes in application name (#3722)

* fix(flameql): allow slashes in application name
grafana · Nov 27, 2024 · 123a3f4 · 123a3f4
1 parent fa69fe0
commit 123a3f4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/pkg/og/flameql/flameql.go b/pkg/og/flameql/flameql.go
@@ -101,7 +101,7 @@ func IsTagKeyRuneAllowed(r rune) bool {
 }
 
 func IsAppNameRuneAllowed(r rune) bool {
-	return r == '-' || r == '.' || IsTagKeyRuneAllowed(r)
+	return r == '-' || r == '.' || r == '/' || IsTagKeyRuneAllowed(r)
 }
 
 func IsTagKeyReserved(k string) bool {

diff --git a/pkg/og/flameql/flameql_test.go b/pkg/og/flameql/flameql_test.go
@@ -70,6 +70,7 @@ var _ = Describe("ValidateAppName", func() {
 
 		testCases := []testCase{
 			{"foo.BAR-1.2_baz_qux", nil},
+			{"namespace/service", nil},
 
 			{"", ErrAppNameIsRequired},
 			{"#", ErrInvalidAppName},