fix: intermitent error on multithread #156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
orlandokj
force-pushed
the
fix/intermitent-multithread-error
branch
from
c580177 to
60ce890
Compare
|
Any updates on this? |
korniltsev
reviewed
Nov 18, 2024
async-profiler-context/src/main/java/io/pyroscope/labels/ScopedContext.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the ScopedContext class to avoid error on closing the scoped context on a diferent thread than it was created.
I had this error on my project when using aws sdk for SQS but I assume it will throw this error for any aws service.
This fix the issue mentioned in #70
I have also created a test that simulates the error, if it doesn't make sense to keep the test, let me know and I will remove it.