Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: run tests on go 1.17 and 1.16 #79

Merged
merged 1 commit into from
Nov 30, 2023
Merged

fix: run tests on go 1.17 and 1.16 #79

merged 1 commit into from
Nov 30, 2023

Conversation

korniltsev
Copy link
Collaborator

@korniltsev korniltsev commented Nov 30, 2023 •
edited
Loading

  • fix running test on 1.17 1.16 (by removing workspace and merging go mod files, downgrading testing dependencies for old go versions)
  • run otel tests on 1.20
  • run go/mod on ci

#76
https://github.com/grafana/pyroscope-go/actions/runs/7041358788/job/19163767980?pr=78

Error: ../../../go/pkg/mod/github.com/klauspost/[email protected]/gzip/gunzip.go:17:2: //go:build comment without // +build comment
Error: Process completed with exit code 1.

@korniltsev korniltsev force-pushed the go16-tests-fix branch 2 times, most recently from 9f52979 to 6d07102 Compare November 30, 2023 05:32
@korniltsev korniltsev changed the title fix: run tests on go 1.16 and 1.17 fix: run tests on go 1.17, drop 1.16 support Nov 30, 2023
@korniltsev korniltsev force-pushed the go16-tests-fix branch 4 times, most recently from fb370be to ad40c5c Compare November 30, 2023 06:23
@korniltsev korniltsev changed the title fix: run tests on go 1.17, drop 1.16 support fix: run tests on go 1.17 and 1.16 Nov 30, 2023
@korniltsev korniltsev force-pushed the go16-tests-fix branch 6 times, most recently from 24fda2b to 24adf19 Compare November 30, 2023 06:37
@korniltsev korniltsev marked this pull request as ready for review November 30, 2023 06:43
@korniltsev korniltsev mentioned this pull request Nov 30, 2023
Merged
kolesnikovae
kolesnikovae approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@kolesnikovae kolesnikovae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@korniltsev korniltsev merged commit abbb381 into main Nov 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolesnikovae kolesnikovae kolesnikovae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@korniltsev @kolesnikovae