Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

godeltaprof: make reading /proc/self/maps lazy #75

Merged
merged 8 commits into from
Nov 30, 2023
Merged

godeltaprof: make reading /proc/self/maps lazy #75

merged 8 commits into from
Nov 30, 2023

Conversation

korniltsev
Copy link
Collaborator

@korniltsev korniltsev commented Nov 29, 2023 •
edited
Loading

#73

goos: linux
goarch: amd64
pkg: github.com/grafana/pyroscope-go/godeltaprof/compat
cpu: AMD Ryzen 9 5950X 16-Core Processor            
                                       │   old.txt    │               new.txt               │
                                       │    sec/op    │    sec/op     vs base               │
HeapRejectOrder-32                       447.3µ ± 16%   279.6µ ± 12%  -37.49% (p=0.002 n=6)
MutexRejectOrder/ScalerMutexProfile-32   411.0µ ± 13%   286.9µ ± 32%  -30.20% (p=0.002 n=6)
MutexRejectOrder/ScalerBlockProfile-32   456.8µ ± 14%   351.4µ ± 20%  -23.07% (p=0.002 n=6)
geomean                                  437.9µ         304.3µ        -30.50%

@korniltsev korniltsev force-pushed the godeltaprof-lazy-mapping3 branch from d97feaf to 7fbb20a Compare November 29, 2023 03:45
@korniltsev korniltsev force-pushed the godeltaprof-lazy-mapping3 branch from 6f8091d to b461dba Compare November 29, 2023 04:14
@korniltsev korniltsev force-pushed the godeltaprof-lazy-mapping3 branch from e84fb83 to 219393a Compare November 29, 2023 04:29
kolesnikovae
kolesnikovae approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@kolesnikovae kolesnikovae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

And for most users it is pretty much always the same between dumps.

I'm wondering why/when that may happen

@korniltsev
Copy link
Collaborator Author

If someone is loading new code in memory

For example dlopen from cgo
Or mmap executable memory

Dont know any other reasons

@korniltsev korniltsev merged commit 2eb5d49 into main Nov 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolesnikovae kolesnikovae kolesnikovae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@korniltsev @kolesnikovae