Create Plugin: Allow setting feature flags via cli args #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackw
added
create-plugin
jackw
force-pushed
the
jackw/expose-flags-to-cli
branch
from
f879305
to
0f5704c
Compare
leventebalogh
approved these changes
Jul 2, 2024
Co-authored-by: Levente Balogh <[email protected]>
jackw
force-pushed
the
jackw/expose-flags-to-cli
branch
from
51417fd
to
9ef654f
Compare
leventebalogh
previously approved these changes
Jul 4, 2024
jackw
dismissed
leventebalogh’s stale review
changed approach making review stale
leventebalogh
force-pushed
the
jackw/expose-flags-to-cli
branch
from
8ce0a9a
to
6a79d7c
Compare
|
🚀 PR was released in |
grafana-plugins-platform-bot
bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR allows users to set feature flags via cli args when scaffolding or updating a plugin. This makes it much easier for users when scaffolding as they don't need to scaffold, create or change the
cprc jsonfile, then run@grafana/create-plugin updateto update the configs. It also makes it easier for contributors to test or add new features behind flags.Feature flags can be passed using the
feature-flagsarg. Multiple can be comma separated. Any unknown flags will produce a warning:Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Use the below canary release feature flags can be set using an arg like
--feature-flags="bundleGrafanaUI".📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via: